[PATCH] D13979: Introduction of FeatureX87

[Andrey Turetskiy via llvm-commits]

aturetsk added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:527
@@ -525,3 +526,3 @@
 
   if (!Subtarget.useSoftFloat() && X86ScalarSSEf64) {
     // f32 and f64 use SSE.
----------------
I believe there is no such hardware and ABI and I agree with not bothering with "-x87,+sse2" case until it's really needed.
So I left UseX87 checks in legalizer only in the places where X87 float register classes are used and added a sanity check (note that it should not be 32-bit specific, it's just happened so that the issue I described had appeared in my testcase in 32 bit mode).

================
Comment at: test/CodeGen/X86/x87.ll:12
@@ +11,3 @@
+; X87: fild
+; NOX87: __floatunsisf
+  %tmp = uitofp i32 %i to float
----------------
Fixed.


http://reviews.llvm.org/D13979