[PATCH] D17372: [PM/AA] Port alias analysis evaluator to the new pass manager, and use it to actually test the new pass manager AA wiring.

[Chandler Carruth via llvm-commits]

chandlerc added a comment.

This is just moving an existing (perhaps bad) comment around. Gonna land the refactoring, happy to keep chatting about how to document this better.

I know I've been doing some tidying and spring cleaning as I refactor things some of the time, I just hadn't here because frankly I'm not an expert on this code and so it seemed like it might better come from others more familiar with it.


================
Comment at: include/llvm/Analysis/AliasAnalysisEvaluator.h:13
@@ +12,3 @@
+// alias analysis implementation answers alias queries between each pair of
+// pointers in the function.
+//
----------------
reames wrote:
> A bit more detail would be good here.  When first reading, I wasn't sure why I might use such a thing.  
> 
> Something along the lines of "The result is a set of statistics about the number of results for each alias result type and modref state returned.  This can be used to evaluate a change in alias analysis implementation, algorithm, or pass ordering."
This is just a move of the original comment. I'd love to have an improvement such as what you suggest, but it probably shouldn't be this patch. Would you be willing to send the improvement? If not, I guess I can. But I don't actually know anything about this pass, so I'm somewhat operating from ignorance here...


http://reviews.llvm.org/D17372