[PATCH] D17374: [X86] PR26575: Fix LEA optimization pass (Part 2)

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 09:37:23 PST 2016


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Andrey,

LGTM modulo few nitpicks.

Thanks,
Q.


================
Comment at: test/CodeGen/X86/lea-opt-memop-check.ll:40
@@ +39,3 @@
+
+define void @test2() #0 {
+entry:
----------------
Could you add a comment on what this test case is checking?

================
Comment at: test/CodeGen/X86/lea-opt-memop-check.ll:56
@@ +55,3 @@
+
+define internal fastcc void @"\01?fin$0 at 0@test2@@"(i8* readonly %frame_pointer) unnamed_addr noinline nounwind optsize {
+entry:
----------------
Ditto.


http://reviews.llvm.org/D17374





More information about the llvm-commits mailing list