[PATCH] D17415: [X86}: Change fixup-bw-inst.ll to test output with this optimization on and off.

[Sanjay Patel via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.
A few notes about LLVM testing in general:

1. For short codegen tests like these, we've been encouraging the use of utils/update_llc_test_checks.py . It automates the check-line creation, so it would've avoided the bug that Quentin noticed. Feel free to try it here. :) After the script does its work, you can reduce the checks as you'd like...
2. But we've been burned by loose regression test checking many times ( https://llvm.org/bugs/show_bug.cgi?id=22897 ). So again, having tighter check lines via the script has benefits...
3. But I understand the point you made in http://reviews.llvm.org/D17173 about test maintenance and focused unit tests. It's an engineering trade-off. If you've had to chase down a few miscompiles, I think you lean towards more tests and more checks rather than less. :)


http://reviews.llvm.org/D17415