[PATCH] D17256: [ELF] - Minor refactor of LinkerScript file.

[George Rimar via llvm-commits]

This revision was automatically updated to reflect the committed changes.
grimar marked 8 inline comments as done.
Closed by commit rL261317: [ELF] - Minor refactor of LinkerScript file (authored by grimar).

Changed prior to commit:
  http://reviews.llvm.org/D17256?vs=48291&id=48469#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D17256

Files:
  lld/trunk/ELF/LinkerScript.cpp

Index: lld/trunk/ELF/LinkerScript.cpp
===================================================================
--- lld/trunk/ELF/LinkerScript.cpp
+++ lld/trunk/ELF/LinkerScript.cpp
@@ -85,7 +85,20 @@
 class elf2::ScriptParser {
 public:
   ScriptParser(BumpPtrAllocator *A, StringRef S, bool B)
-      : Saver(*A), Tokens(tokenize(S)), IsUnderSysroot(B) {}
+      : Saver(*A), Tokens(tokenize(S)), IsUnderSysroot(B) {
+    Cmd["ENTRY"] = &ScriptParser::readEntry;
+    Cmd["EXTERN"] = &ScriptParser::readExtern;
+    Cmd["GROUP"] = &ScriptParser::readGroup;
+    Cmd["INCLUDE"] = &ScriptParser::readInclude;
+    Cmd["INPUT"] = &ScriptParser::readGroup;
+    Cmd["OUTPUT"] = &ScriptParser::readOutput;
+    Cmd["OUTPUT_ARCH"] = &ScriptParser::readOutputArch;
+    Cmd["OUTPUT_FORMAT"] = &ScriptParser::readOutputFormat;
+    Cmd["SEARCH_DIR"] = &ScriptParser::readSearchDir;
+    Cmd["SECTIONS"] = &ScriptParser::readSections;
+    Cmd[";"] = [](ScriptParser &) {};
+  }
+
   void run();
 
 private:
@@ -114,37 +127,21 @@
 
   StringSaver Saver;
   std::vector<StringRef> Tokens;
-  bool Error = false;
+  llvm::StringMap<std::function<void(ScriptParser &)>> Cmd;
   size_t Pos = 0;
   bool IsUnderSysroot;
+  bool Error = false;
 };
 
 void ScriptParser::run() {
   while (!atEOF()) {
     StringRef Tok = next();
-    if (Tok == ";")
-      continue;
-    if (Tok == "ENTRY") {
-      readEntry();
-    } else if (Tok == "EXTERN") {
-      readExtern();
-    } else if (Tok == "GROUP" || Tok == "INPUT") {
-      readGroup();
-    } else if (Tok == "INCLUDE") {
-      readInclude();
-    } else if (Tok == "OUTPUT") {
-      readOutput();
-    } else if (Tok == "OUTPUT_ARCH") {
-      readOutputArch();
-    } else if (Tok == "OUTPUT_FORMAT") {
-      readOutputFormat();
-    } else if (Tok == "SEARCH_DIR") {
-      readSearchDir();
-    } else if (Tok == "SECTIONS") {
-      readSections();
+    auto It = Cmd.find(Tok);
+    if (It != Cmd.end()) {
+      std::function<void(ScriptParser &)> &Handler = It->second;
+      Handler(*this);
     } else {
       setError("unknown directive: " + Tok);
-      return;
     }
   }
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17256.48469.patch
Type: text/x-patch
Size: 2131 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160219/3f942def/attachment.bin>