[PATCH] D15369: [mips] Make symbols an acceptable branch target when expanding compare-to-immediate-and-branch macros.

Vasileios Kalintiris via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 19 02:31:05 PST 2016


vkalintiris accepted this revision.
vkalintiris added a reviewer: vkalintiris.
vkalintiris added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2516
@@ -2515,3 +2515,2 @@
   const MCOperand &MemOffsetOp = Inst.getOperand(2);
-  assert(MemOffsetOp.isImm() && "expected immediate operand kind");
 
----------------
Instead of removing the assertion, it would be nice to keep it and OR it with isExpr().


http://reviews.llvm.org/D15369





More information about the llvm-commits mailing list