[PATCH] D17433: [ARM] fix initialization of PredictableSelectIsExpensive; NFC

Junmo Park via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 18:24:21 PST 2016


flyingforyou created this revision.
flyingforyou added a reviewer: jmolloy.
flyingforyou added subscribers: evandro, llvm-commits.
Herald added subscribers: rengolin, aemerson.

If we want classify OoO or not, using getSchedModel().isOutOfOrder() could be more proper way than using Subtarget->isLikeA9().

http://reviews.llvm.org/D17433

Files:
  lib/Target/ARM/ARMISelLowering.cpp

Index: lib/Target/ARM/ARMISelLowering.cpp
===================================================================
--- lib/Target/ARM/ARMISelLowering.cpp
+++ lib/Target/ARM/ARMISelLowering.cpp
@@ -1042,7 +1042,7 @@
   setMinStackArgumentAlignment(4);
 
   // Prefer likely predicted branches to selects on out-of-order cores.
-  PredictableSelectIsExpensive = Subtarget->isLikeA9();
+  PredictableSelectIsExpensive = Subtarget->getSchedModel().isOutOfOrder();
 
   setMinFunctionAlignment(Subtarget->isThumb() ? 1 : 2);
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17433.48446.patch
Type: text/x-patch
Size: 518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160219/4a8cc216/attachment.bin>


More information about the llvm-commits mailing list