[PATCH] D17377: [ADT]Fix AddPointer() in FoldingSet

[Sean Silva via llvm-commits]

On Thu, Feb 18, 2016 at 1:57 PM, Eugene via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> kevgs added a comment.
>
> Linux AMD64, but I have no problems with that code. I just thought it was
> incorrect and feel pretty silly now. However, patched method looks nicer
> and it's probably faster because compiler is not forced to put variable on
> the stack ;)
>

`AddInteger((uintptr_t)Ptr)` does seem cleaner and doesn't assume the
compiler is going to do magic to make the "append" faster.

-- Sean Silva


>
> Anyway, thanks four your help and sorry for taking your time on such a
> stupid case.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D17377
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160218/c0f1ab7a/attachment.html>