[PATCH] D17350: [AArch64][ShrinkWrap] Fix bug in prolog clobbering live reg when shrink wrapping.

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 17:00:57 PST 2016


qcolombet added inline comments.

================
Comment at: test/CodeGen/AArch64/arm64-shrink-wrapping.ll:645
@@ +644,3 @@
+; ENABLE-DAG: str w[[DIV2]],
+
+define i32 @stack_realign(i32 %a, i32 %b, i32* %ptr1, i32* %ptr2) {
----------------
I know this is painful (I’ve done quite a few time already ;)), but could you add the DISABLE check and regular CHECK to minimize the ENABLE/DISABLE differences.

================
Comment at: test/CodeGen/AArch64/arm64-shrink-wrapping.ll:672
@@ +671,3 @@
+; ENABLE: add x29, sp, #{{[0-9]+}}
+; ENABLE: lsl {{w[0-9]+}}, w0, w1
+
----------------
In this case, since both shrink-wrapped and non-shrink-wrapped tests are the same, you should use CHECK lines everywhere.


http://reviews.llvm.org/D17350





More information about the llvm-commits mailing list