[PATCH] D16836: [CodeGenPrepare] Don't transform select instructions into branches when both of operands are cheap

Junmo Park via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 16:45:03 PST 2016


flyingforyou added a comment.

Thanks Sanjay.

> As Mitch pointed out, there's certainly demand to do the transform(s) here because it's easier. And now that I realize we have access to the same SchedModel info that we would use at the machine-level anyway, it seems more reasonable. However, as Hal and Mehdi have noted, breaking up a basic block may harm isel/scheduling.


I totally agree with this. I will change this patch soon.

Thanks for pointing `ARMISelLowering.cpp`.


http://reviews.llvm.org/D16836





More information about the llvm-commits mailing list