[PATCH] D17008: [lanai] Add ELF enum value and relocations

Jacques Pienaar via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 13:26:04 PST 2016


jpienaar marked an inline comment as done.

================
Comment at: include/llvm/Support/ELFRelocs/Lanai.def:6
@@ +5,3 @@
+
+ELF_RELOC(R_LANAI_NONE,        0)
+ELF_RELOC(R_LANAI_21,          1)
----------------
eliben wrote:
> Would this be a good place for a few lines of comments explaining each relocation type?
Looking at the other backends, the relocation types are not normally documented in ELFRelocs/X.def. Rather the explanation of relocation types is commonly done in lib/Target/X/MCTargetDesc/XFixupKinds.h.


http://reviews.llvm.org/D17008





More information about the llvm-commits mailing list