[PATCH] D17351: [zorg] Addition of extraLitArgs variable to ClangAndLLDBuilder.py

[Galina via llvm-commits]

gkistanova added inline comments.

================
Comment at: zorg/buildbot/builders/ClangAndLLDBuilder.py:111
@@ -119,1 +110,3 @@
+        lit_args += extraLitArgs
+    lit_args_str = "-DLLVM_LIT_ARGS=\"%s\"" % (" ".join(lit_args))
 
----------------
Maybe just let user define -DLLVM_LIT_ARGS with extraCmakeOptions param instead? With a meaningful default, let's say "-v".
This way it would be clear of how a particular builder is configured.

With the current approach, you may end up having multiple conflicting -DLLVM_LIT_ARGS, one coming from extraCmakeOptions, and the other one coming from extraLitArgs.

The other option is to assert on having  -DLLVM_LIT_ARGS in extraCmakeOptions. This is up to you which option to choose.



http://reviews.llvm.org/D17351