[PATCH] D17400: [CaptureTracking] Support atomicrmw and cmpxchg

[Philip Reames via llvm-commits]

reames created this revision.
reames added reviewers: jfb, sanjoy, nicholas.
reames added a subscriber: llvm-commits.
Herald added a subscriber: mcrosier.

These atomic operations are conceptually both a load and store from the same location.  As such, we can treat them as the most conservative of those two components which in practice, means we can treat them like stores.  An cmpxchg or atomicrmw captures the values, but not the locations accessed.

Note: We can probably be more aggressive about the comparison value in an cmpxhg since to have it be in memory, it must already be captured, but I figured it was better to avoid that for the moment.  

Note 2: It turns out that since we don't actually support cmpxchg of pointer type, writing a negative test is impossible.

http://reviews.llvm.org/D17400

Files:
  lib/Analysis/CaptureTracking.cpp
  test/Transforms/FunctionAttrs/nocapture.ll

Index: test/Transforms/FunctionAttrs/nocapture.ll
===================================================================
--- test/Transforms/FunctionAttrs/nocapture.ll
+++ test/Transforms/FunctionAttrs/nocapture.ll
@@ -193,3 +193,14 @@
   ret void
 }
 
+; CHECK: define void @test_cmpxchg(i32* nocapture %p)
+define void @test_cmpxchg(i32* %p) {
+  cmpxchg i32* %p, i32 0, i32 1 acquire monotonic
+  ret void
+}
+
+; CHECK: define void @test_atomicrmw(i32* nocapture %p)
+define void @test_atomicrmw(i32* %p) {
+  atomicrmw add i32* %p, i32 1 seq_cst
+  ret void
+}
Index: lib/Analysis/CaptureTracking.cpp
===================================================================
--- lib/Analysis/CaptureTracking.cpp
+++ lib/Analysis/CaptureTracking.cpp
@@ -271,6 +271,17 @@
           return;
       // Storing to the pointee does not cause the pointer to be captured.
       break;
+    case Instruction::AtomicRMW:
+    case Instruction::AtomicCmpXchg:
+      // atomicrmw and cmpxchg conceptually include both a load and store from
+      // the same location.  As with a store, the location being accessed is
+      // not captured, but the value being stored is.  (For cmpxchg, we
+      // probably don't need to capture the original comparison value, but for
+      // the moment, let's be conservative.)
+      if (V != I->getOperand(0))
+        if (Tracker->captured(U))
+          return;
+      break;
     case Instruction::BitCast:
     case Instruction::GetElementPtr:
     case Instruction::PHI:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17400.48355.patch
Type: text/x-patch
Size: 1504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160218/2dc4a783/attachment.bin>