[PATCH] D17398: [CMake] Properly set CMAKE_BUILD_TYPE to Debug by default

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 10:31:07 PST 2016


beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.

Actually I don't think this is the right solution.

The CMAKE_BUILD_TYPE variable needs to be cached. Setting it can stay where it is as long as the set command caches.
Changing:

  set(CMAKE_BUILD_TYPE "Debug")

-to-

  set(CMAKE_BUILD_TYPE "Debug" CACHE STRING "Build type (default Debug)")

Should fix the bug.


http://reviews.llvm.org/D17398





More information about the llvm-commits mailing list