[PATCH] D17178: Add profile summary support for sample profile

Diego Novillo via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 09:52:36 PST 2016


dnovillo accepted this revision.
dnovillo added a comment.
This revision is now accepted and ready to land.

Thanks for the new feature!  LGTM with one minor nit.


================
Comment at: include/llvm/ProfileData/SampleProfReader.h:299
@@ +298,3 @@
+  /// \brief Return the profile summary.
+  SampleProfSummary &getSummary() { return *(Summary.get()); }
+
----------------
As a matter of consistency, let's keep the naming to SampleProfile instead of SampleProf.  I know it's not really "consistent" because instruction profiles use InstrProf, but at least we make it consistent within the sample profiler :)


http://reviews.llvm.org/D17178





More information about the llvm-commits mailing list