[PATCH] D17242: [ELF] - Linkerscript KEEP command.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 18 01:55:48 PST 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:395
@@ +394,3 @@
+  expect("(");
+  while (!skip(")")) {
+    SectionRule R = {OutSec, next()};
----------------
ruiu wrote:
> Did you test this code with an incomplete input? I think this will fall into an infinite loop if you give
> 
>   SECTIONS { .foo : { KEEP(
Hmm you're right, my mistake.


http://reviews.llvm.org/D17242





More information about the llvm-commits mailing list