[PATCH] D17245: Add support for memory operations (load/store/gep) in C API echo test

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 17 14:50:37 PST 2016


deadalnix added inline comments.

================
Comment at: include/llvm-c/Core.h:2568
@@ +2567,3 @@
+LLVMBool LLVMIsInBounds(LLVMValueRef GEP);
+void LLVMSetIsInBounds(LLVMValueRef GEP, LLVMBool b);
+
----------------
joker.eph wrote:
> Doxygen.
You got it.

================
Comment at: tools/llvm-c-test/echo.cpp:243
@@ +242,3 @@
+  if (LLVMIsAConstantAggregateZero(Cst))
+    return LLVMConstNull(TypeCloner(M).Clone(Cst));
+
----------------
joker.eph wrote:
> Is it related to the C API addition/modification done in this patch?
The test case use a zeroinitializer, and that's how you get one from the API.


http://reviews.llvm.org/D17245





More information about the llvm-commits mailing list