[PATCH] D17346: [LIR] Avoid turning non-temporal stores into memset.

[Haicheng Wu via llvm-commits]

haicheng created this revision.
haicheng added reviewers: mcrosier, gberry, mssimpso.
haicheng added a subscriber: llvm-commits.
haicheng set the repository for this revision to rL LLVM.
Herald added subscribers: mzolotukhin, mcrosier.

This is to fix [[ https://llvm.org/bugs/show_bug.cgi?id=26645 | PR26645 ]].

Repository:
  rL LLVM

http://reviews.llvm.org/D17346

Files:
  lib/Transforms/Scalar/LoopIdiomRecognize.cpp
  test/Transforms/LoopIdiom/nontemporal_store.ll

Index: test/Transforms/LoopIdiom/nontemporal_store.ll
===================================================================
--- /dev/null
+++ test/Transforms/LoopIdiom/nontemporal_store.ll
@@ -0,0 +1,31 @@
+; RUN: opt -loop-idiom < %s -S | FileCheck %s
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+%struct.bigBlock_t = type { [256 x <4 x float>] }
+
+; CHECK-LABEL: @test(
+; CHECK-NOT: llvm.memset
+define void @test(%struct.bigBlock_t* %p) {
+entry:
+  %0 = getelementptr inbounds %struct.bigBlock_t, %struct.bigBlock_t* %p, i64 0, i32 0, i64 0, i64 0
+  br label %for.body
+
+for.body:                                         ; preds = %entry, %for.body
+  %index.02 = phi i32 [ 0, %entry ], [ %add, %for.body ]
+  %dst.01 = phi float* [ %0, %entry ], [ %add.ptr2, %for.body ]
+  %cast.i5 = bitcast float* %dst.01 to <4 x float>*
+  store <4 x float> zeroinitializer, <4 x float>* %cast.i5, align 16, !nontemporal !0
+  %add.ptr1 = getelementptr inbounds float, float* %dst.01, i64 4
+  %cast.i = bitcast float* %add.ptr1 to <4 x float>*
+  store <4 x float> zeroinitializer, <4 x float>* %cast.i, align 16, !nontemporal !0
+  %add.ptr2 = getelementptr inbounds float, float* %dst.01, i64 8
+  %add = add nuw nsw i32 %index.02, 32
+  %cmp = icmp ult i32 %add, 4096
+  br i1 %cmp, label %for.body, label %for.end
+
+for.end:                                          ; preds = %for.body
+  ret void
+}
+
+!0 = !{i32 1}
Index: lib/Transforms/Scalar/LoopIdiomRecognize.cpp
===================================================================
--- lib/Transforms/Scalar/LoopIdiomRecognize.cpp
+++ lib/Transforms/Scalar/LoopIdiomRecognize.cpp
@@ -314,6 +314,10 @@
   if (!SI->isSimple())
     return false;
 
+  // Avoid merging nontemporal stores.
+  if (SI->getMetadata(LLVMContext::MD_nontemporal))
+    return false;
+
   Value *StoredVal = SI->getValueOperand();
   Value *StorePtr = SI->getPointerOperand();
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17346.48227.patch
Type: text/x-patch
Size: 1972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160217/055ed7c6/attachment.bin>