[PATCH] D15976: Supporting all entities declared in lexical scope in LLVM debug info

[David Blaikie via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Just simplify the finishLocalScopeDefinitions call as suggested & please commit after that. (no need for another round of review, the change is simple/obvious enough)


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:547
@@ +546,3 @@
+  for (const auto &I : CUMap)
+    forBothCUs(*I.second, [&](DwarfCompileUnit &CU) {
+      CU.finishLocalScopeDefinitions();
----------------
Just looking at the code, I think the right thing here is just to call:

  I.second->finishLocalScopeDefinitions()

We shouldn't have any local scope definitions in the skeleton CU, so the other call is just a no-op anyway, so far as I can tell.


http://reviews.llvm.org/D15976