[PATCH] D17314: Update langref to indicate that calls may be convergent.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 23:30:47 PST 2016


joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.

I think the last paragraph may be enough to me. Please see the two nits.


================
Comment at: docs/LangRef.rst:1252
@@ -1249,3 +1251,3 @@
 
-    The optimizer may remove the ``convergent`` attribute when it can prove
-    that the function does not execute any convergent operations.
+    When the appears on a call/invoke, the ``convergent`` attribute indicates
+    that we should treat the call as though we're calling a convergent
----------------
"When the appears" does not seem right to me. "When it appears"?

================
Comment at: docs/LangRef.rst:1260
@@ -1252,1 +1259,3 @@
+    Similarly, the optimizer may remove ``convergent`` on calls/invokes when it
+    can prove that the call/invoke does not run a convergent function.
 ``inaccessiblememonly``
----------------
"does not run" sounds odd, what about "can call" instead?


http://reviews.llvm.org/D17314





More information about the llvm-commits mailing list