[llvm] r260812 - HexagonFrameLowering.cpp: Appease msc18 to give an explicit constructor SlotInfo() instead of member initializers.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 15:53:57 PST 2016


On Tue, Feb 16, 2016 at 3:12 PM, NAKAMURA Takumi <geek4civic at gmail.com>
wrote:

> Regarding to LLD, are they POD? I
>

Ah, that may be it. LLD has a lot of POD.

-- Sean Silva


>
> On Wed, Feb 17, 2016 at 4:50 AM Sean Silva <chisophugis at gmail.com> wrote:
>
>> On Fri, Feb 12, 2016 at 11:29 PM, NAKAMURA Takumi via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> Author: chapuni
>>> Date: Sat Feb 13 01:29:49 2016
>>> New Revision: 260812
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=260812&view=rev
>>> Log:
>>> HexagonFrameLowering.cpp: Appease msc18 to give an explicit constructor
>>> SlotInfo() instead of member initializers.
>>>
>>
>> LLD uses member initializers a lot. Does msc18 have issues with LLD? Why
>> do we nee a workaround in HexagonFrameLowering.cpp?
>>
>> -- Sean Silva
>>
>>
>>> Modified:
>>>     llvm/trunk/lib/Target/Hexagon/HexagonFrameLowering.cpp
>>>
>>> Modified: llvm/trunk/lib/Target/Hexagon/HexagonFrameLowering.cpp
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonFrameLowering.cpp?rev=260812&r1=260811&r2=260812&view=diff
>>>
>>> ==============================================================================
>>> --- llvm/trunk/lib/Target/Hexagon/HexagonFrameLowering.cpp (original)
>>> +++ llvm/trunk/lib/Target/Hexagon/HexagonFrameLowering.cpp Sat Feb 13
>>> 01:29:49 2016
>>> @@ -1718,8 +1718,10 @@ void HexagonFrameLowering::optimizeSpill
>>>
>>>    struct SlotInfo {
>>>      BlockRangeMap Map;
>>> -    unsigned Size = 0;
>>> -    const TargetRegisterClass *RC = nullptr;
>>> +    unsigned Size;
>>> +    const TargetRegisterClass *RC;
>>> +
>>> +    SlotInfo() : Map(), Size(0), RC(nullptr) {}
>>>    };
>>>
>>>    BlockIndexMap BlockIndexes;
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160216/dacf8e83/attachment.html>


More information about the llvm-commits mailing list