[PATCH] D17241: [Polly] [Refactor] Move isl_ctx into Scop.

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 06:52:47 PST 2016


grosser added a comment.

I am a little worried about both of these changes. Will we still be warned if we forgot to release a pointer or are will we just stop to free isl_ctx due to the wrong order of freeing items.

Also, I am surprised why this works today without any troubles? For whatever reason today it seems to be ensured that we free everything else before the ScopInfo pass has been freed. Eithers observation of the different pass order somehow suggests that this should not be the case, but it still magically works. Do you understand why this currently works despite the pass freeing being reversed?


http://reviews.llvm.org/D17241





More information about the llvm-commits mailing list