[PATCH] D17235: [Greedy Regalloc] Reg splitting based on loops

[Quentin Colombet via llvm-commits]

qcolombet added a comment.

Hi Wei,

Thanks for looking into this.
I haven't looked at the details of the patch, but here are a few comments:

- The PHIElimination pass already has an option to SplitAllCriticalEdges. Please check how we can use this instead of introducing a new pass.
- The split around regions should already consider loops. Why is this not doing the right thing? Could you work toward improving the heuristic there instead of introducing another splitting scheme?

Cheers,
-Quentin


Repository:
  rL LLVM

http://reviews.llvm.org/D17235