[llvm] r260880 - Reverted r260879 as it caused test failures in lld.

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 06:04:29 PST 2016


Hi Scott,

On Mon, Feb 15, 2016 at 1:04 PM, Scott Egerton via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> ==============================================================================
> --- llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp (original)
> +++ llvm/trunk/lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp Mon Feb 15 04:04:38 2016
> @@ -611,7 +611,7 @@ void MipsTargetELFStreamer::emitDirectiv
>    MCStreamer &OS = getStreamer();
>
>    MCSectionELF *Sec = Context.getELFSection(".pdr", ELF::SHT_PROGBITS,
> -                                            ELF::SHT_REL);
> +                                            ELF::SHF_ALLOC | ELF::SHT_REL);

Both initial and new variants of this code look strange. The third
argument of getELFSection is ELF section flags. But ELF::SHT_REL is a
section type. I think the correct one should be as follow:

MCSectionELF *Sec = Context.getELFSection(".pdr", ELF::SHT_PROGBITS, 0);

As far as I understand by lld failure you mean got16-micro.test.
Right? Fill free to commit the changes. I will change this test case
after that.

-- 
Simon Atanasyan


More information about the llvm-commits mailing list