[PATCH] D17241: [Refactor] Move isl_ctx into Scop.

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 02:27:43 PST 2016


grosser added a comment.

Hi ether,

I think moving the isl_ctx into the scop is good, but similarly to Johannes I do not yet understand the use of the shared-ptr. All isl objects take plain pointers, so the shared pointer itself goes very quickly out-of-scope. My feeling is that this very same change should work already without shared pointers. If it does not, then we likely have a memory issue that is just be covered by shared pointers. ether: when not using shared pointers, which element is freed only after we try to free the isl_ctx?


Repository:
  rL LLVM

http://reviews.llvm.org/D17241





More information about the llvm-commits mailing list