[PATCH] D17241: [Refactor] Move isl_ctx into Scop.

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 13 08:00:25 PST 2016


jdoerfert added inline comments.

================
Comment at: lib/Analysis/ScopInfo.cpp:2800
@@ -2800,1 +2799,3 @@
     isl_set_free(std::get<2>(IAClass));
+
+  isl_ctx_free(IslCtx);
----------------
You have to free __all__ isl_objects that were created with this Ctx first. Missing are at least:
  - The ScopArrayInfoObjects
  - The Statements
    - The MemoryAccesses
Maybe even more.


```
Stmts.clear();            // Takes care of all Statement objects
AccFuncMap.clear();       //  ... " " ........ MemoryAccesses objects
ScopArrayInfoMap.clear(); //  ... " " ........ ScopArrayInfo objects
```

Did that catch all?


Repository:
  rL LLVM

http://reviews.llvm.org/D17241





More information about the llvm-commits mailing list