[PATCH] D17241: [Refactor] Use ManagedStatic to manage the global isl_ctx.

Hongbin Zheng via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 13 07:06:03 PST 2016


etherzhhb added a comment.

In http://reviews.llvm.org/D17241#352224, @jdoerfert wrote:

> I think this is not what we want. Globals are always bad when we think about parallel execution of passes. While we __still__ have a global map flying around that nobody cares to remove we... we should not introduce new globals that will break the assumption that non-connected parts of the module can be compiled concurrently. As an alternative I would suggest to move the isl_ctx into the Scop class and let it deal correctly with deallocating all derived objects once it (the Scop) is deleted.


I agree that we should move the isl_ctx to Scop.


Repository:
  rL LLVM

http://reviews.llvm.org/D17241





More information about the llvm-commits mailing list