[PATCH] D17196: [test-suite] Use cmake `find_package` to search zLib for ClamAV test case

[Simon Atanasyan via llvm-commits]

atanasyan added a comment.

In http://reviews.llvm.org/D17196#351593, @MatzeB wrote:

> - cmake also offers https://cmake.org/cmake/help/v3.0/module/FindZLIB.html how does that compare to find_package(ZLIB)?


find_package(ZLIB) uses FindZLIB module to find zLib. In general, as far as I understand if you have FindSOMETHING module you need to use find_package(SOMETHING) to search the corresponding package.

> - I'd just disable the whole benchmark if libz couldn't be found instead of trying anyway.


I am afraid a bit that somebody just copy target specific libz.so and zlib.h to say the single directory. In that case find_package does not find the library. But if we disable the whole benchmark the cmake code becomes shorter. So I modify the script this way and commit. If somebody stumble to this problem we will know how to fix it.

> In any way this is simple enough to just commit (there's always post-commit review).


Thanks for review.


Repository:
  rL LLVM

http://reviews.llvm.org/D17196