[PATCH] D17042: AMDGPU/SI: move SMRD to flat if UseFlatForGlobal is true

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 12:19:01 PST 2016


arsenm added a comment.

In http://reviews.llvm.org/D17042#350691, @cfang wrote:

> In http://reviews.llvm.org/D17042#348771, @arsenm wrote:
>
> > Can you split this into functions? We might want to re-use this in other places
>
>
> This is to translate smrd ( with sbase in VGPR) to flat. I can not what other places need this translation.
>  I would factor out to a function when we are working on a case that need re-use.


Functions are also more readable. The various moveToVALU instructions are already too big


http://reviews.llvm.org/D17042





More information about the llvm-commits mailing list