[PATCH] D16771: [ELF] PHDRS linker script command implemented.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 06:23:22 PST 2016


grimar added inline comments.

================
Comment at: ELF/Writer.cpp:1209
@@ +1208,3 @@
+template <class ELFT> void Writer<ELFT>::createPhdrsFromScript() {
+  // Reserve for total PHDRS amount + 1 for "NONE" synthetic PHDR.
+  Phdrs.reserve(Script->Phdrs.size() + 1);
----------------
Btw, is it supposed that createPhdrsFromScript() stuff should go to LinkerScript.cpp ?
Problem is that here the field of Writer is changed (Phdrs) and also methods and <ELFT> is used which I am not sure would look good in linkerscript files.


http://reviews.llvm.org/D16771





More information about the llvm-commits mailing list