[PATCH] D16940: Fix build LLVM with -D LLVM_USE_INTEL_JITEVENTS:BOOL=ON on Windows

[Chris Bieneman via llvm-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

One minor comment, but LGTM.


================
Comment at: lib/ExecutionEngine/IntelJITEvents/CMakeLists.txt:17
@@ +16,2 @@
+
+add_dependencies(LLVMIntelJITEvents LLVMCodeGen)
----------------
andrew.w.kaylor wrote:
> I'm not 100% sure that the change I made matches what you are suggesting, but it appears to fix the problem in the 3.8 branch.
Just a nitpick. When linking LLVM components instead of calling add_dependencies you can set LLVM_LINK_COMPONENTS before calling add_llvm_library.

Adding something like this to the top of the file is the more normal way to handle this:


```
set(LLVM_LINK_COMPONENTS Support)
```


Repository:
  rL LLVM

http://reviews.llvm.org/D16940