[PATCH] D17015: ARM: Introduce conservative load/store optimization mode

[Renato Golin via llvm-commits]

rengolin added inline comments.

================
Comment at: lib/Target/ARM/ARMLoadStoreOptimizer.cpp:67
@@ +66,3 @@
+static cl::opt<bool>
+ConservativeARMLoadStoreOpt("arm-conservative-load-store", cl::Hidden,
+    cl::init(false), cl::desc("Be more conservative in ARM load/store opt"));
----------------
Maybe a name that has more to do with alignment?

Like "arm-unaligned-load-store", enabled by default?

================
Comment at: test/CodeGen/ARM/ldrd.ll:19
@@ -16,3 +18,3 @@
 define void @test_ldrd(i64 %a) nounwind readonly {
-; CHECK-LABEL: test_ldrd:
+; ALL-LABEL: test_ldrd:
 ; CHECK: bl{{x?}} _get_ptr
----------------
The preferred way is to omit the check-prefix and use CHECK for "ALL".


Repository:
  rL LLVM

http://reviews.llvm.org/D17015