[PATCH] D17041: [X86] Don't assume that a shuffle operand is #0: it isn't for VPERMV.

[Simon Pilgrim via llvm-commits]

RKSimon added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:23658
@@ -23621,1 +23657,3 @@
+  }
+
   // At the moment we can only combine target shuffle unary cases.
----------------
Was there a need to add this? We already have all undef and all undef/zero handling below and in combineX86ShuffleChain

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:24335
@@ -24289,3 +24334,3 @@
   SDValue N0 = N->getOperand(0);
   SDValue N1 = N->getOperand(1);
   EVT VT = N->getValueType(0);
----------------
Don't these need dealing with as well? Also at the moment the getOperand(1) calls means that unary target shuffles can't use this combine as they would assert....


http://reviews.llvm.org/D17041