[llvm] r260392 - [llvm-nm] Add -radix option

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 13:29:29 PST 2016


On 10 February 2016 at 12:51, Hemant Kulkarni via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: khemant
> Date: Wed Feb 10 11:51:39 2016
> New Revision: 260392
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260392&view=rev
> Log:
> [llvm-nm] Add -radix option
>
> Differential Revision: http://reviews.llvm.org/D16822
>
> Added:
>     llvm/trunk/test/tools/llvm-nm/X86/radix/
>     llvm/trunk/test/tools/llvm-nm/X86/radix/Inputs/
>     llvm/trunk/test/tools/llvm-nm/X86/radix/Inputs/radix.asm
>     llvm/trunk/test/tools/llvm-nm/X86/radix/lit.local.cfg
>     llvm/trunk/test/tools/llvm-nm/X86/radix/radix.test

The code is fine, but please fix the test to look like other llvm tests:

* You don't need the radix subdirectory.
* You can use a sigle radix.s file instead of having a radix.test and
a radix.asm


More information about the llvm-commits mailing list