[PATCH] D17028: [ThinLTO] Use MD5 hash in function index.

[Xinliang David Li via llvm-commits]

I meant the op1 part can be simplified -- but not necessariliy need to.

David

On Wed, Feb 10, 2016 at 9:53 AM, Teresa Johnson <tejohnson at google.com> wrote:
> tejohnson added inline comments.
>
> ================
> Comment at: test/tools/gold/X86/thinlto.ll:27-31
> @@ -26,5 +26,7 @@
>  ; COMBINED-NEXT: <VALUE_SYMTAB
> -; COMBINED-NEXT: <COMBINED_FNENTRY {{.*}} record string = '{{f|g}}'
> -; COMBINED-NEXT: <COMBINED_FNENTRY {{.*}} record string = '{{f|g}}'
> +; Check that the format is: op0=offset, op1=funcguid, where funcguid is
> +; the lower 64 bits of the function name MD5.
> +; COMBINED-NEXT: <COMBINED_FNENTRY abbrevid={{[0-9]+}} op0={{[0-9]+}} op1={{-3706093650706652785|-5300342847281564238}}
> +; COMBINED-NEXT: <COMBINED_FNENTRY abbrevid={{[0-9]+}} op0={{[0-9]+}} op1={{-3706093650706652785|-5300342847281564238}}
>  ; COMBINED-NEXT: </VALUE_SYMTAB
>
> ----------------
> I think that's what I have here already? I could shorten this a bit by replacing the intermediate parts with {{.*}}. E.g.:
>
> ; COMBINED-NEXT: <COMBINED_FNENTRY {{.*}} {{-3706093650706652785|-5300342847281564238}}
>
> Is that preferable?
>
>
> http://reviews.llvm.org/D17028
>
>
>