[PATCH] D15393: [X86] Order the local stack symbols to improve code size and locality.

[Zia Ansari via llvm-commits]

zansari updated this revision to Diff 47420.
zansari added a comment.

Thanks, David, for the review.. And thanks, Sean, for the additional data and analysis on your workloads. I'm glad it showed positive results for you.

David, I think I addressed all of your concerns.. The one I left open was the one regarding what size I assign to variable size symbols.. I couldn't think of any number that made sense, so I just arbitrarily picked 4. I figured that 1 would probably make less sense, since most allocas, for example, would probably be > 1B. If you feel 1 would make more sense, I wouldn't have any issues changing it. I doubt it would make much different in the grand scheme of things.

Thanks,
Zia.


http://reviews.llvm.org/D15393

Files:
  include/llvm/CodeGen/CommandFlags.h
  include/llvm/Target/TargetFrameLowering.h
  include/llvm/Target/TargetOptions.h
  lib/CodeGen/PrologEpilogInserter.cpp
  lib/Target/X86/X86FrameLowering.cpp
  lib/Target/X86/X86FrameLowering.h
  test/CodeGen/X86/2009-02-12-DebugInfoVLA.ll
  test/CodeGen/X86/aligned-variadic.ll
  test/CodeGen/X86/cleanuppad-realign.ll
  test/CodeGen/X86/dynamic-allocas-VLAs.ll
  test/CodeGen/X86/hipe-cc.ll
  test/CodeGen/X86/hipe-cc64.ll
  test/CodeGen/X86/local-stack-symbol-ordering.ll
  test/CodeGen/X86/phys-reg-local-regalloc.ll
  test/CodeGen/X86/seh-catch-all-win32.ll
  test/CodeGen/X86/seh-stack-realign.ll
  test/CodeGen/X86/ssp-data-layout.ll
  test/CodeGen/X86/statepoint-stack-usage.ll
  test/CodeGen/X86/statepoint-stackmap-format.ll
  test/CodeGen/X86/stdarg.ll
  test/CodeGen/X86/widen_load-1.ll
  test/CodeGen/X86/win-catchpad-varargs.ll
  test/CodeGen/X86/win-catchpad.ll
  test/CodeGen/X86/win32-seh-catchpad-realign.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15393.47420.patch
Type: text/x-patch
Size: 31502 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160210/ce00ba53/attachment.bin>