[PATCH] D17046: AMDGPU: Document address space mapping

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: docs/AMDGPUUsage.rst:24
@@ +23,3 @@
+   0             Private
+   1             Global (RAT0, VTX0)
+   2             Constant
----------------
RAT0, VTX0 is only R600. I would probably just omit these

================
Comment at: docs/AMDGPUUsage.rst:27
@@ +26,3 @@
+   3             Local
+   4             Flat
+   5             Region
----------------
The OpenCL terminology is generic. Maybe Flat (generic)?

================
Comment at: docs/AMDGPUUsage.rst:29-30
@@ +28,4 @@
+   5             Region
+   6             Direct addressible parameter (CONST0)
+   7             Indirect addressible parameter memory (VTX1)
+   ============= ============================================
----------------
I would drop these two. We may change these to match HSAIL and they aren't really used.


http://reviews.llvm.org/D17046