[PATCH] D16931: [codeview] Describe int local variables using .cv_def_range

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:569
@@ +568,3 @@
+  OS.AddComment("TypeIndex");
+  OS.EmitIntValue(TypeIndex::Int32().getIndex(), 4);
+  OS.AddComment("Flags");
----------------
dblaikie wrote:
> Some comments here might not go astray (what is the format of these records you're emitting (maybe a broad comment at the top describing the format overall, then details on each field))
> 
> Specifically I don't know what the 4 here and 2, below (flags), are.
They (4 and 2) are the size of the value in bytes.  Otherwise, `EmitIntValue` wouldn't know how much data to emit.


http://reviews.llvm.org/D16931