[PATCH] D16383: Change ConstantFoldInstOperands to take Instruction instead of opcode and type. NFC.

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 13:28:26 PST 2016


Hey Manuel,
Will you have time to address these issues?

If not, i'm tempted to revert this set of changes.
While I agree with your end goals of supporting the pointer type changes,,
right now i see unaddressed issues with this particular implementation
As I'm sure you know, comments and issues in reviews after commit need to
be addressed the same as pre-commit reviews and it's been about 2 weeks.
.
So if you won't have time to tackle this, that's fine, but we should just
probably revert it until you (or someone else) does have the time to tackle
this :)

--Dan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160209/ccd8fad7/attachment.html>


More information about the llvm-commits mailing list