[PATCH] D17028: [ThinLTO] Use MD5 hash in function index.

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:5466
@@ -5456,4 +5465,3 @@
       uint64_t FuncOffset = Record[1];
-      std::unique_ptr<FunctionInfo> FuncInfo =
-          llvm::make_unique<FunctionInfo>(FuncOffset);
-      if (foundFuncSummary() && !IsLazy) {
+      assert(!IsLazy && "Lazy summary read only supported for combined index");
+      // Gracefully handle bitcode without a function summary section,
----------------
Is the assert unrelated change?

================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:823
@@ +822,3 @@
+  // Emit the module's source file name.
+  {
+    StringEncoding Bits =
----------------
This code looks like a common utility (string emission) -- is there any code reuse opportunity?


http://reviews.llvm.org/D17028