[compiler-rt] r260167 - [asan] Fix Windows build.

[Hans Wennborg via llvm-commits]

Sorry, I meant to say, the error is from
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/6273/steps/gclient%20runhooks/logs/stdio
(LLVM r260171)

On Mon, Feb 8, 2016 at 3:47 PM, Hans Wennborg <hans at chromium.org> wrote:
> Windows builds are failing:
>
> C:\b\build\slave\ClangToTWin\build\src\third_party\llvm\projects\compiler-rt\lib\sanitizer_common\sanitizer_win.cc(750)
> : error C2665: '__sanitizer::SignalContext::SignalContext' : none of
> the 2 overloads could convert all the argument types
>         c:\b\build\slave\clangtotwin\build\src\third_party\llvm\projects\compiler-rt\lib\sanitizer_common\sanitizer_common.h(756):
> could be '__sanitizer::SignalContext::SignalContext(void
> *,__sanitizer::uptr,__sanitizer::uptr,__sanitizer::uptr,__sanitizer::uptr,bool,__sanitizer::SignalContext::WriteFlag)'
>         while trying to match the argument list '(void *,
> __sanitizer::uptr, __sanitizer::uptr, __sanitizer::uptr,
> __sanitizer::uptr, bool, bool)'
>
> On Mon, Feb 8, 2016 at 3:01 PM, Evgeniy Stepanov via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: eugenis
>> Date: Mon Feb  8 17:01:06 2016
>> New Revision: 260167
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=260167&view=rev
>> Log:
>> [asan] Fix Windows build.
>>
>> Modified:
>>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc
>>
>> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc
>> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc?rev=260167&r1=260166&r2=260167&view=diff
>> ==============================================================================
>> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc (original)
>> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc Mon Feb  8 17:01:06 2016
>> @@ -744,10 +744,10 @@ SignalContext SignalContext::Create(void
>>  #endif
>>    uptr access_addr = exception_record->ExceptionInformation[1];
>>
>> -  bool is_write = false;  // FIXME: compute this.
>> -  bool is_memory_access = false;  // FIXME: compute this.
>> +  bool write_flag = SignalContext::UNKNOWN;  // FIXME: compute this.
>> +  bool is_memory_access = false;             // FIXME: compute this.
>>    return SignalContext(context, access_addr, pc, sp, bp, is_memory_access,
>> -                       is_write);
>> +                       write_flag);
>>  }
>>
>>  uptr ReadBinaryName(/*out*/char *buf, uptr buf_len) {
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits