[PATCH] D16762: llvm-config: Add preliminary Windows support

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 15:31:35 PST 2016


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: lib/Support/CMakeLists.txt:2-6
@@ -1,4 +1,7 @@
 set(system_libs)
-if( NOT MSVC )
+if( MSVC )
+  # libuuid required for FOLDERID_Profile usage in lib/Support/Windows/Path.inc.
+  set(system_libs ${system_libs} psapi shell32 ole32 uuid)
+else()
   if( MINGW )
     # libuuid required for FOLDERID_Profile usage in lib/Support/Windows/Path.inc.
----------------
Seems simpler as 
  if (MSVC OR MINGW)
    set(system_libs ${system_libs} psapi shell32 ole32 uuid)
  elseif (CMAKE_HOST_UNIX)
    ...



http://reviews.llvm.org/D16762





More information about the llvm-commits mailing list