[llvm] r260146 - [PGO] Differentiate Clang instrumentation and IR level instrumentation profiles

[Rong Xu via llvm-commits]

Tim,

Thanks for sending me the errors.  I'm kind of surprised to see this error:
I generate the variable in IR level profiling only. I not sure why the
variable got generate in clang instrumentation.

I'll revert my patch and do some investigation.

Thanks,

-Rong

On Mon, Feb 8, 2016 at 2:49 PM, Tim Northover <t.p.northover at gmail.com> wrote:
> Hi Rong,
>
> This seems to have broken a test in compiler-rt on Darwin platforms
> because we don't have COMDAT. See
> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/10077/
> for example.
>
> I think you probably just want to make the variable linkonce (or
> perhaps linkonce_odr) for us. Theoretically that could be removed as
> unused, but ld64 doesn't seem to without special options and I don't
> think there's a better lowering.
>
> Cheers.
>
> Tim.