[PATCH] D16120: [ThinLTO] Remove imported available externally defs from comdats.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 10:01:33 PST 2016


joker.eph requested changes to this revision.
joker.eph added a reviewer: joker.eph.
joker.eph added a comment.
This revision now requires changes to proceed.

LGTM


================
Comment at: lib/Linker/LinkModules.cpp:733
@@ +732,3 @@
+  // Remove functions imported as available externally defs from comdats,
+  // as this is a declaration for the linker, and will be dropped eventually.
+  // It is illegal for comdats to contain declarations.
----------------
Ok I didn't know it was illegal :)


http://reviews.llvm.org/D16120





More information about the llvm-commits mailing list