[PATCH] D16907: [X86] Don't zero/sign-extend i1 or i8 return values to 32 bits (PR22532)

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 7 09:57:55 PST 2016

spatel accepted this revision.
spatel added a reviewer: spatel.
spatel added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D16907#345786, @zansari wrote:

> We could play it safe and only do this for opt/min-size, or go ahead with this if the impact is low and deal with any potential performance issue in a more general way. Have we done any perf tests on this to see if there's any impact?

I haven't run any perf tests, but I thought it would be good to alert people about this change since there might be some diffs.

I agree that dealing with any perf issue as a separate pass is the better option, and Kevin mentioned some progress on that here:

This patch LGTM; it's just trying to match the ABI's mandates and as noted, makes LLVM behave more like GCC/MSVC by default.


More information about the llvm-commits mailing list