[PATCH] D16959: Separate invariant equivalence classes by type

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 7 06:30:48 PST 2016

grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

Hi Johannes,

thank you for fixing this. The changes look good to me, but it would be great if you could update the comments and possibly add 2-3 sentences in the commit message to make it easier for people to get the context of this change.


Comment at: include/polly/CodeGen/IslNodeBuilder.h:212
@@ -211,3 +211,3 @@
   /// @brief Set to remember materialized invariant loads.
-  SmallPtrSet<const SCEV *, 16> PreloadedPtrs;
+  SmallSet<std::pair<const SCEV *, Type *>, 16> PreloadedPtrs;
Maybe mention this in the comment?

Comment at: include/polly/ScopInfo.h:857
@@ -856,3 +856,3 @@
 using InvariantEquivClassTy =
-    std::tuple<const SCEV *, MemoryAccessList, isl_set *>;
+    std::tuple<const SCEV *, MemoryAccessList, isl_set *, Type *>;
The comment seems to still need an update.


More information about the llvm-commits mailing list