[PATCH] D16885: [mips] Extend MipsAsmParser class to handle %got(sym + const) expressions

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 7 04:25:07 PST 2016

atanasyan added a comment.

In http://reviews.llvm.org/D16885#344953, @rafael wrote:

> LGTM, but can you make the test more specific? The current one passes if I change 1004 to 1003 for example.

Thanks for review.

Do you change first or second or both 0x10004? If you change only the first one in the `lw` instruction, it is expected that the test passes because `%got()` takes upper 16-bits of the value. I use two instructions and two relocations in the test because such pair of relocations is a common case in the code.



More information about the llvm-commits mailing list