[PATCH] D16950: Compute live-in for MemorySSA

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 6 14:07:31 PST 2016


dberlin added inline comments.

================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:264
@@ -261,2 +263,3 @@
       if (isa<MemoryDef>(MA))
-        DefiningBlocks.insert(&B);
+        InsertIntoDef = true;
+      else if (isa<MemoryUse>(MA))
----------------
In case the change made here isn't obvious - we used to try to insert the block into the set *for each relevant instruction we found in the block* (IE N attempts per block), and now we only insert it into the set once per block.



http://reviews.llvm.org/D16950





More information about the llvm-commits mailing list