[PATCH] D16909: Add AMDGPU related triple vendors/OSes

Marek Olšák via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 12:51:05 PST 2016

mareko added inline comments.

Comment at: lib/Support/Triple.cpp:451
@@ -444,1 +450,3 @@
+    .StartsWith("clover", Triple::Clover)
+    .StartsWith("radeonsi", Triple::RadeonSI)
arsenm wrote:
> tstellarAMD wrote:
> > I'm not sure about this one.  It only really makes sense to use this with the amdgcn target.  It seems like maybe this should be something more generic (mesa?).  
> Neither am I. Mesa should definitely be the vendor though, not the OS. Michel said on IRC that a mesa vulkan driver will probably end up using a different ABI, so we will probably need to distinguish those.
AFAIK, there won't be any Mesa Vulkan driver. The Vulkan driver will be a completely separate project.


More information about the llvm-commits mailing list