[PATCH] D16909: Add AMDGPU related triple vendors/OSes
Eric Christopher via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 5 12:23:22 PST 2016
Well you don't need a separate triple to handle an abi difference.
TargetOptions can take an abi name.
On Fri, Feb 5, 2016, 12:18 PM Matt Arsenault <Matthew.Arsenault at amd.com>
> arsenm added inline comments.
> Comment at: lib/Support/Triple.cpp:451
> @@ -444,1 +450,3 @@
> + .StartsWith("clover", Triple::Clover)
> + .StartsWith("radeonsi", Triple::RadeonSI)
> tstellarAMD wrote:
> > I'm not sure about this one. It only really makes sense to use this
> with the amdgcn target. It seems like maybe this should be something more
> generic (mesa?).
> Neither am I. Mesa should definitely be the vendor though, not the OS.
> Michel said on IRC that a mesa vulkan driver will probably end up using a
> different ABI, so we will probably need to distinguish those.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits